search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.41k stars 1.22k forks source link

Fix footer styling issue #6004

Open rohitsrma opened 4 weeks ago

rohitsrma commented 4 weeks ago

Currently, in the footer of our website's documentation section, the 'Next' and 'Previous' links are shown in front of the page's title, and they have different font sizes. I'm sure this wasn't done on purpose. The problem is because the title and the navigation links are in the same class, which messes up the styles.

To fix this, I moved the footer text outside of that class. This way, the existing styles won't get overridden by the class styles.

Before

image

After

image

knative-prow[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rohitsrma Once this PR has been reviewed and has the lgtm label, please assign davidhadas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 4 weeks ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 0d51a46d24a37775723d51443ecd67191ab92262
Latest deploy log https://app.netlify.com/sites/knative/deploys/665e29126f19cc0008e233c4
Deploy Preview https://deploy-preview-6004--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Cali0707 commented 4 weeks ago

/cc @zainabhusain227 @mmejia02