search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.41k stars 1.22k forks source link

Remove old warning about istio and external-domain-tls #6015

Closed ReToCode closed 2 weeks ago

ReToCode commented 2 weeks ago

Changes

ReToCode commented 2 weeks ago

/assign @dprotaso

/cherry-pick release-1.14

knative-prow-robot commented 2 weeks ago

@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to [this](https://github.com/knative/docs/pull/6015#issuecomment-2167234194): >/assign @dprotaso > >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 2 weeks ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 41a8c04c7e534f420a5ad89b1d266eb91783db43
Latest deploy log https://app.netlify.com/sites/knative/deploys/666bd3b63c5e9b000847fda3
Deploy Preview https://deploy-preview-6015--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dprotaso commented 2 weeks ago

/lgtm /approve

knative-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[docs/serving/OWNERS](https://github.com/knative/docs/blob/main/docs/serving/OWNERS)~~ [ReToCode,dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow-robot commented 2 weeks ago

@ReToCode: new pull request created: #6018

In response to [this](https://github.com/knative/docs/pull/6015#issuecomment-2167234194): >/assign @dprotaso > >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.