search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.56k stars 1.23k forks source link

responsive styling for case study section on Home page #6065

Closed ShravaniAK closed 3 months ago

ShravaniAK commented 4 months ago

I have made the case study section on Home page responsive on all devices .

netlify[bot] commented 4 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 973f99bc74dfd08a769277e3fa36cd675afa07e5
Latest deploy log https://app.netlify.com/sites/knative/deploys/66c70d9de6fe69000811dd94
Deploy Preview https://deploy-preview-6065--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ShravaniAK commented 4 months ago

/cc @Cali0707 @zainabhusain227 @aliok

ShravaniAK commented 3 months ago

I have worked on the feedback that was received during the UX meet,

  1. in mobile view, made the card wider
  2. also in the mobile view aligned the text in the center
Cali0707 commented 3 months ago

@ShravaniAK thank you for the changes, we will try and do a final review tomorrow in the UX meeting

Leo6Leo commented 3 months ago

The PR is approved during the UX WG meeting. But please fix the merging conflict before we proceed. Thank you for the great work @ShravaniAK

Cali0707 commented 3 months ago

Hey @ShravaniAK can you fix the merge conflicts so that we can merge this?

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, ShravaniAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)~~ [Cali0707] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment