search

knative / docs

User documentation for Knative components.
https://knative.dev/docs/
Other
4.56k stars 1.23k forks source link

made top three sections of home page responsive #6068

Closed ShravaniAK closed 2 months ago

ShravaniAK commented 4 months ago

I have made top three sections of home page responsive.

netlify[bot] commented 4 months ago

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
Latest commit 1154a157c865284e53f5628e7ca527c9429fe684
Latest deploy log https://app.netlify.com/sites/knative/deploys/66bcafba5c48bd0008752433
Deploy Preview https://deploy-preview-6068--knative.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ShravaniAK commented 4 months ago

/cc @zainabhusain227 @Cali0707 @aliok

ShravaniAK commented 3 months ago

I have worked on the feedback that was received in the meet, I have made the following changes:

  1. fixed the line break in the "need to know more section"
  2. fixed the size of the text in the "Why serverless container"
  3. reduced the empty gap between the icons of "Why serverless container" section.
Cali0707 commented 3 months ago

@ShravaniAK thank you! We will try and do a final review of this PR tomorrow in the UX meeting

Leo6Leo commented 3 months ago

Review result from UX WG meeting: 2024-08-08 @ShravaniAK

Decision: Change requested

Comments:

ShravaniAK commented 3 months ago

I have made the requested changes , thanks

knative-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, ShravaniAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/docs/blob/main/OWNERS)~~ [Cali0707] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment