search

knative / eventing-contrib

Event Sources
Apache License 2.0
226 stars 225 forks source link

DeepCopy the entire set of conditions (#128) #1645

Closed lionelvillard closed 3 years ago

lionelvillard commented 3 years ago

backporting https://github.com/knative-sandbox/eventing-kafka/pull/128

lionelvillard commented 3 years ago

@matzew

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
kafka/source/pkg/apis/sources/v1alpha1/kafka_conversion.go 94.1% 94.4% 0.3
kafka/source/pkg/apis/sources/v1beta1/fuzzer.go Do not exist 100.0%
matzew commented 3 years ago

/lgtm /approve

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/eventing-contrib/blob/release-0.18/OWNERS)~~ [lionelvillard,matzew] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment