search

knative / eventing-contrib

Event Sources
Apache License 2.0
226 stars 225 forks source link

[0.17] KafkaBinding conversion problems #1648

Closed aliok closed 3 years ago

aliok commented 3 years ago

Describe the bug Getting this on 0.17 branch:

"level":"error","ts":"2020-10-27T07:37:16.393Z","logger":"kafka-controller.ConversionWebhook","caller":"controller/controller.go:526","msg":"Reconcile error","error":"custom resource \"kafkabindings.bindings.knative.dev\" isn't configured for webhook conversion",

Expected behavior No error

To Reproduce Create a KafkaSource with a ksvc sink

Knative release version 0.17 Tried with eventing v0.17.7 and eventing-contrib v0.17.4

Additional context Add any other context about the problem here such as proposed priority

aliok commented 3 years ago

@mattmoor have you seen something like that with KafkaBinding? I think you were using KafkaBinding

aliok commented 3 years ago

I think KafkaBinding CRD is missing following: :facepalm:

  conversion:
    strategy: Webhook
    webhookClientConfig:
      service:
        name: kafka-source-webhook
        namespace: knative-sources
mattmoor commented 3 years ago

Yeah you need that block for conversion.

cc @dprotaso

aliok commented 3 years ago

/close

Fixed by https://github.com/knative/eventing-contrib/pull/1651

knative-prow-robot commented 3 years ago

@aliok: Closing this issue.

In response to [this](https://github.com/knative/eventing-contrib/issues/1648#issuecomment-717534717): >/close > >Fixed by https://github.com/knative/eventing-contrib/pull/1651 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.