search

knative / eventing-contrib

Event Sources
Apache License 2.0
224 stars 225 forks source link

[0.17] Fix KafkaBinding conversion #1651

Closed aliok closed 3 years ago

aliok commented 3 years ago

Fixes #1648

Proposed Changes

Release Note

- 🐛 Fix bug
Fix KafkaBinding conversion

Docs

aliok commented 3 years ago

/assign @vaikas Pretty much the same thing as https://github.com/knative/eventing-contrib/pull/1650 but also has a small fix for #1648

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
kafka/source/pkg/apis/bindings/v1alpha1/kafka_conversion.go 86.7% 85.7% -1.0
knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[kafka/OWNERS](https://github.com/knative/eventing-contrib/blob/release-0.17/kafka/OWNERS)~~ [matzew] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aliok commented 3 years ago

Cherry pick on 0.18: https://github.com/knative/eventing-contrib/pull/1652 Cherry pick on master: https://github.com/knative-sandbox/eventing-kafka/pull/144