search

knative / eventing-contrib

Event Sources
Apache License 2.0
226 stars 225 forks source link

[0.18] Backport: Adding global TLS/SASL for the KafkaChannel #1667

Closed matzew closed 3 years ago

matzew commented 3 years ago

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

bringing sandbox PR to here: https://github.com/knative-sandbox/eventing-kafka/pull/211

matzew commented 3 years ago

/assign @lberk /assign @aliok

Can one of you take a looksie?

lionelvillard commented 3 years ago

Why are you opening a PR here vs backporting a yet-to-be-done PR in knative-sandbox?

matzew commented 3 years ago

Why are you opening a PR here vs backporting a yet-to-be-done PR in knative-sandbox?

Just a matter of where I started :-) I will port forward, on Monday - or later :-)

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
kafka/channel/pkg/dispatcher/dispatcher.go Do not exist 64.3%
kafka/channel/pkg/reconciler/controller/kafkachannel.go Do not exist 53.5%
kafka/channel/pkg/utils/util.go Do not exist 94.7%
kafka/client.go Do not exist 70.7%
kafka/kafka_scram_client.go Do not exist 0.0%
knative-prow-robot commented 3 years ago

@matzew: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-eventing-contrib-go-coverage 17c9958599245da4579b62d8c0cc6b8d1511afb2 link /test pull-knative-eventing-contrib-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
aliok commented 3 years ago

/lgtm /approve

Ignoring linting check

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/eventing-contrib/blob/release-0.18/OWNERS)~~ [aliok,matzew] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
matzew commented 3 years ago

Ignoring linting check

I have no idea what's wrong here... tbh