Closed lberk closed 3 years ago
action failures seem to be unrelated to the actual PR
The following is the coverage report on the affected files.
Say /test pull-knative-eventing-contrib-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
kafka/client.go | Do not exist | 75.0% | |
kafka/source/pkg/apis/bindings/v1alpha1/kafka_conversion.go | Do not exist | 85.7% | |
kafka/source/pkg/apis/bindings/v1alpha1/kafka_lifecycle.go | Do not exist | 57.1% | |
kafka/source/pkg/apis/bindings/v1alpha1/kafka_types.go | Do not exist | 100.0% | |
kafka/source/pkg/apis/bindings/v1beta1/kafka_lifecycle.go | Do not exist | 57.1% | |
kafka/source/pkg/apis/bindings/v1beta1/kafka_types.go | Do not exist | 100.0% | |
kafka/source/pkg/reconciler/source/resources/receive_adapter.go | Do not exist | 100.0% |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: lberk, matzew
The full list of commands accepted by this bot can be found here.
The pull request process is described here
knative-sandbox/eventing-kafka#237 backport
Add kafkasource SASL Type
Add unit tests for NewConfig in source client
wip, Add tests, lifecycle, e2e test
Fix v1alpha1 conversion, tests
Refactor tests
Change kafkabinding sasltype json to 'Type'
Rework test call structure
#