knative / eventing-contrib

Event Sources
Apache License 2.0
226 stars 225 forks source link

fix label consistency #1671

Closed skonto closed 3 years ago

skonto commented 3 years ago

Backport of this.

knative-prow-robot commented 3 years ago

Welcome @skonto! It looks like this is your first PR to knative/eventing-contrib 🎉

knative-prow-robot commented 3 years ago

Hi @skonto. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
matzew commented 3 years ago

/ok-to-test

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[kafka/OWNERS](https://github.com/knative/eventing-contrib/blob/release-0.18/kafka/OWNERS)~~ [matzew] - ~~[test/OWNERS](https://github.com/knative/eventing-contrib/blob/release-0.18/test/OWNERS)~~ [matzew] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
kafka/source/pkg/reconciler/source/resources/labels.go Do not exist 100.0%