search

knative / eventing-contrib

Event Sources
Apache License 2.0
226 stars 225 forks source link

fix custom consumer group error channel lifecycle (#263) #1676

Closed lionelvillard closed 3 years ago

lionelvillard commented 3 years ago

Backport https://github.com/knative-sandbox/eventing-kafka/pull/263

Proposed Changes

Release Note

 🐛 Fix crash in Kafka consumer when a rebalance occurs

Docs

knative-metrics-robot commented 3 years ago

The following is the coverage report on the affected files. Say /test pull-knative-eventing-contrib-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
kafka/common/pkg/kafka/consumer_factory.go Do not exist 81.8%
kafka/common/pkg/kafka/consumer_handler.go Do not exist 89.5%
knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[kafka/OWNERS](https://github.com/knative/eventing-contrib/blob/release-0.18/kafka/OWNERS)~~ [lionelvillard] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment