knative / eventing

Event-driven application platform for Kubernetes
https://knative.dev/docs/eventing
Apache License 2.0
1.41k stars 587 forks source link

Removing a step in a sequence does not properly update the underlying resources #2005

Closed lionelvillard closed 3 years ago

lionelvillard commented 5 years ago

Describe the bug Removing a step in a sequence does not properly update the underlying resources.

Expected behavior Removing a step in a sequence should properly update the underlying resources.

To Reproduce Create a sequence with 3 steps, then remove the last one.

Knative release version 0.8.0+

lionelvillard commented 4 years ago

@akashrv Can you create milestone v0.13.0. I'd like to defer all issues related to flow to 0.13.

/milestone v0.13.0

knative-prow-robot commented 4 years ago

@lionelvillard: You must be a member of the knative/knative-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/knative/eventing/issues/2005#issuecomment-564560923): >@akashrv Can you create milestone v0.13.0. I'd like to defer all issues related to flow to 0.13. > >/milestone v0.13.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
grantr commented 4 years ago

/assign @zargarpur

github-actions[bot] commented 4 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

lionelvillard commented 3 years ago

/remove-lifecycle stale

github-actions[bot] commented 3 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

lionelvillard commented 3 years ago

/remove-lifecycle stale

github-actions[bot] commented 3 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

pierDipi commented 3 years ago

This seems to be still an issue.

/triage accepted

odacremolbap commented 3 years ago

Can I get assigned this one please?

pierDipi commented 3 years ago

/assign @odacremolbap

Hi Pablo, you can directly comment /assign to get an issue assigned to you.

lionelvillard commented 3 years ago

thanks @odacremolbap !