search

knative / eventing

Event-driven application platform for Kubernetes
https://knative.dev/docs/eventing
Apache License 2.0
1.41k stars 590 forks source link

Problems terminating knative-eventing namespace because of config-br-defaults #2919

Closed matzew closed 4 years ago

matzew commented 4 years ago

Describe the bug

The "core" defines a config map for the broker config-br-defaults, and the same is provided by the two different broker impls

Now, when you install bits, like:

ko apply -f config/
...
ko apply -f config/channels/in-memory-channel
...
ko apply -f config/brokers/(mt-)channel-broker

you get a working knative.

But it is currently not possible to remove the knative-eventing, when doing a serious of ko delete to uninstall the above componets. When running the final ko delete -f config/, it stucks with:

" not found
Error from server (NotFound): error when deleting "config/500-webhook-secret.yaml": secrets "eventing-webhook-certs" not found
2020/04/07 15:33:53 error executing "kubectl" command with args: [delete -f config/]; exit status 1

the knative-eventing namespace stays in Terminating state:

k get ns                    
NAME               STATUS        AGE
default            Active        50m
knative-eventing   Terminating   36m
knative-serving    Active        49m
kourier-system     Active        49m
kube-node-lease    Active        50m
kube-public        Active        50m
kube-system        Active        50m

and inside it I get some left-overs:

k get all -nknative-eventing
NAME                                  READY   REASON   URL                                                                                 AGE
broker.eventing.knative.dev/default   True             http://broker-ingress.knative-eventing.svc.cluster.local/knative-eventing/default   24m

NAME                                                        READY   REASON   URL                                                                        AGE
inmemorychannel.messaging.knative.dev/default-kne-trigger   True             http://default-kne-trigger-kn-channel.knative-eventing.svc.cluster.local   24m

Expected behavior

clean up is all simple and works

Knative release version

HEAD

matzew commented 4 years ago

some related issue: https://github.com/knative/eventing/issues/2889

matzew commented 4 years ago

/assign

matzew commented 4 years ago

@k4leung4 @aliok something relevant for the upstream operator, when doing the broker field, I guess

matzew commented 4 years ago

@houshengbo see ^

matzew commented 4 years ago

/close

this now fixed, with recent config changes

knative-prow-robot commented 4 years ago

@matzew: Closing this issue.

In response to [this](https://github.com/knative/eventing/issues/2919#issuecomment-611412659): >/close > >this now fixed, with recent config changes Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.