Closed matzew closed 1 year ago
Actually:
If events are routed to a channel created/owned by the broker controller, we should not create these event types
@matzew pls do you have a quick hint where is the routing happening to check if we can infer the ownership?
@dsimansk are you working on this? If not, I can take it :)
@Cali0707 go ahead I was just poking around, but haven't found a good starting point. :)
/assign
@matzew it looks like this is happening because the TypeMeta
is not properly set on the Broker
object used in the ingress_handler.go
. The TypeMeta
is always initially set correctly, however after the first call to getBroker
https://github.com/knative/eventing/blob/7636997cd0b81d3846948726fa5d7b9a41c584e0/pkg/broker/ingress/ingress_handler.go#L126-L130
the Broker
object stored in the indexer changes to have no TypeMeta
set, so when we access the broker object when creating events there is no TypeMeta
anymore. Also, on subsequent http requests, there is no TypeMeta
- only on the first request it is set.
Temporarily, we can fix this by just hardcoding the TypeMeta
, but I think we should try and figure out what the problem is - WDYT?
Describe the bug
Create a broker like:
and than send some random event to it, like:
You will not see an
EventType
for the broker: just the channel. However, the channel is just an implementation detail, and is OK that it is listed there, on the ingress, but for sure it should also show this for the Broker.Result: