search

knative / eventing

Event-driven application platform for Kubernetes
https://knative.dev/docs/eventing
Apache License 2.0
1.41k stars 588 forks source link

Merge TLS and OIDC e2e tests #7638

Open creydr opened 8 months ago

creydr commented 8 months ago

Currently the TLS and OIDC e2e tests are mostly redundant and test the same (e.g. both have test to test the reply & DLS). Mostly the only difference is, that the OIDC tests configure an audience.

Therefor we should check, which OIDC and TLS tests can be merged and merge both "suites" together.

Hint:

parth721 commented 7 months ago

Hi @creydr, I am interested in this issue and want to gain more experience in this topic as a beginner.

creydr commented 7 months ago

Hello @parth721, thanks for showing interest in this issue :+1: Anyhow, in case you're new to knative or the code base, I think a good-first-issue could be a good start to get into the code bases and the development process. You can check for good-first-issues e.g. here: https://github.com/search?q=org%3Aknative+org%3Aknative-extensions++label%3A%22good+first+issue%22+is%3Aissue+is%3Aopen+&type=issues. In case you want to "prepare" for these issues, check for TLS or OIDC related issues.

Anyhow if you feel confident for this issue already, feel free to assign it to you.

parth721 commented 7 months ago

Hey @creydr, you are right, picking a goodfirst issues to understand the codebase is a great idea, but the catch is that all the issues are assigned, and some issues are merged anywhere else but kept open as goood first issue( 1yr old). Are these issues still kept opened for beginners or is there any labels similar to good first issue(level 2) :). what about difficulty level of flaky issues ? I don't know much about them, but i'm happy to learn.

prajjwalyd commented 3 months ago

Hey @creydr, I was going through the tests yesterday and noticed that TestMTChannelBrokerRotateTLSCertificates and TestBrokerSupportsOIDC from broker_test.go, as well as (to some extent) TestInMemoryChannelTLS and TestChannelImplSupportsOIDC from channel_test.go, have a significant overlap in environment setup and focus on similar functionalities. I think merging these tests into single functions with clear subtests would indeed streamline our test suite... I'm looking to fix this issue and wanted to confirm if my identification is correct or if there are some other aspects left to consider.

Thanks!

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.