Closed creydr closed 2 months ago
/assign
Hey @varshith257, This issue is ready to be worked on. You can also check on #8014, how we solved this for the Channel (particularly on https://github.com/knative/eventing/pull/8014/commits/b7ff773d20de19d1e7a278103f4a6a14d7e06f9b and https://github.com/knative/eventing/pull/8014/commits/789113828e15b3a27434667a74e98e04a9aefa8d). Please let us know if you have any questions :)
Thanks! Will fix it soon
On Mon, 24 Jun, 2024, 8:29 pm Christoph Stäbler, @.***> wrote:
Hey @varshith257 https://github.com/varshith257, This issue is ready to be worked on. You can also check on #8014 https://github.com/knative/eventing/pull/8014, how we solved this for the Channel (particularly on b7ff773 https://github.com/knative/eventing/commit/b7ff773d20de19d1e7a278103f4a6a14d7e06f9b and 7891138 https://github.com/knative/eventing/commit/789113828e15b3a27434667a74e98e04a9aefa8d ). Please let us know if you have any questions :)
— Reply to this email directly, view it on GitHub https://github.com/knative/eventing/issues/7979#issuecomment-2186786256, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4BF3HBGFJMH3BTCKKYRSOLZJAX6PAVCNFSM6AAAAABJB2L2CGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBWG44DMMRVGY . You are receiving this because you were mentioned.Message ID: @.***>
Hello @varshith257 , Any updates on this? As this issue in in iteration 2 which ends next week (July 6th), please let us know if you'll be able to finish it till then (please also count some time for review cycles). If you don't find time for it, please unassign yourself, so that another contributor could pick this up.
@creydr Yes I will complete it soon and raise PR by tommorow. I have exams so hadn't done any progress on this. Sorry for it
Hey @varshith257, thanks for the update. Good luck with your exams. I only wanted to make sure that we're aligned on the timeline
hey @varshith257 since this is due end of this week and we are running short of time, would you mind if I assign the issue to myself? You can pick other issues once your exams are over ?
@rahulii Working on it. Will submit a PR soon abiding timeline
@rahulii: As we didn't see any progress on this, I think you can take this over if you want
/assign
/unassign @varshith257
As the Eventing Authorization feature track describes, target resources of
EventPolicies
, will reflect in their status, whichEventPolicy
is applied to them.For example:
As the Parallel should support
EventPolicies
, wee need to do the following:.status.policies
and set the ParallelEventPoliciesReady
condition. Also watch EventPolicies for changes.EventPoliciesReady
condition to true, in case no policy applies, and setmessage
according to thedefault-authorization-mode
(e.g.Default authorization mode is 'allow-all'
). Check the Default Authorization Mode section in the feature track for additional information.Hint:
AppliedEventPoliciesStatus
to the Parallel is done in #7975Prerequisites:
7985
7975
Additional hints for new contributors before starting with this issue:
Draft
status, the issue is subject to change and thus should not be started to be worked on/assign
). Please be aware that we might unassign you, if we don't see any progress from your side to give other contributors also a chance to work on this issue.