List applying EventPolicies in Sequence status

rahulii commented 2 weeks ago

Fixes #7978

Proposed Changes

🎁 List EventPolicies in the Sequence .status.policies, which apply for it.
🎁 Add the EventPoliciesReady condition to indicate, if the referenced policies are Ready

Pre-review Checklist

[ ] At least 80% unit test coverage
[ ] E2E tests for any new behavior
[ ] Docs PR for any user-facing impact
[ ] Spec PR for any new API feature
[ ] Conformance test for any change to the spec

Release Note

List applying EventPolicies in Sequence status

Docs

knative-prow[bot] commented 2 weeks ago

Hi @rahulii. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

creydr commented 1 week ago

Hello @rahulii, thanks for your work so far on this. Do you need any more details to continue here? You can also check on #8014, how we solved this for the Channel (particularly on https://github.com/knative/eventing/pull/8014/commits/b7ff773d20de19d1e7a278103f4a6a14d7e06f9b and https://github.com/knative/eventing/pull/8014/commits/789113828e15b3a27434667a74e98e04a9aefa8d). Please let us know if you have any questions :)

rahulii commented 1 week ago

@creydr thanks for the references, will get this done.

creydr commented 5 days ago

Hello @rahulii, any updates on this?

rahulii commented 5 days ago

Hello @rahulii, any updates on this?

hey @creydr yes I was trying to understand the changes on your PR - particularly this func - https://github.com/knative/eventing/pull/8014/files#diff-118d54e11363ce17cd0de2c082c234f0dcd47f4d1078f58d1d6b0866a091886bR128

creydr commented 5 days ago

hey @creydr yes I was trying to understand the changes on your PR - particularly this func - https://github.com/knative/eventing/pull/8014/files#diff-118d54e11363ce17cd0de2c082c234f0dcd47f4d1078f58d1d6b0866a091886bR128

Hey @rahulii, this was only specific to the Channel implementation, as we needed to copy the policy also to the backing channel. This is not needed for the Sequence. I guess you can focus mostly on something like https://github.com/knative/eventing/pull/8014/commits/b7ff773d20de19d1e7a278103f4a6a14d7e06f9b and https://github.com/knative/eventing/pull/8014/commits/789113828e15b3a27434667a74e98e04a9aefa8d

creydr commented 5 days ago

/ok-to-test

rahulii commented 5 days ago

hey @creydr yes I was trying to understand the changes on your PR - particularly this func - https://github.com/knative/eventing/pull/8014/files#diff-118d54e11363ce17cd0de2c082c234f0dcd47f4d1078f58d1d6b0866a091886bR128

Hey @rahulii, this was only specific to the Channel implementation, as we needed to copy the policy also to the backing channel. This is not needed for the Sequence. I guess you can focus mostly on something like b7ff773 and 7891138

ah gotcha!

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.92%. Comparing base (3b1bfb4) to head (8b2ede3).

Files	Patch %	Lines
pkg/apis/flows/v1/sequence_lifecycle.go	50.00%	4 Missing :warning:
pkg/reconciler/testing/v1/sequence.go	84.21%	3 Missing :warning:
pkg/reconciler/sequence/sequence.go	50.00%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8012 +/- ## ========================================== + Coverage 67.89% 67.92% +0.02% ========================================== Files 366 366 Lines 17115 17154 +39 ========================================== + Hits 11621 11651 +30 - Misses 4773 4781 +8 - Partials 721 722 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, rahulii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/eventing/blob/main/OWNERS)~~ [creydr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

knative / eventing