[main] Upgrade to latest dependencies

knative-automation commented 3 months ago

Cron -knative-prow-robot

/cc knative/eventing-writers /assign knative/eventing-writers

Produced by: knative-extensions/knobots/actions/update-deps

creydr commented 3 months ago

This seems to be an "issue" caused by the update from 1.21 to 1.22 and loop vars:

with go 1.21 in go.mod:

$ go test ./test/rekt/features/broker/... -run TestCreateExpectedEventPatterns
ok      knative.dev/eventing/test/rekt/features/broker  0.015s

$ GOEXPERIMENT=loopvar go test ./test/rekt/features/broker/... -run TestCreateExpectedEventPatterns
--- FAIL: TestCreateExpectedEventPatterns (0.00s)
    --- FAIL: TestCreateExpectedEventPatterns/t1,_one_retry,_one_failure,_both_t0_/_t1_get_it,_t1dlq_gets_it_too (0.00s)
        topology_test.go:227: t1, one retry, one failure, both t0 / t1 get it, t1dlq gets it too: Maps unequal: want:
            map[brokerdlq:{Success:[] Interval:[]} t0:{Success:[true] Interval:[0]} t0dlq:{Success:[] Interval:[]} t1:{Success:[false true] Interval:[0 0]} t1dlq:{Success:[true] Interval:[0]}]
            got:
            map[brokerdlq:{Success:[] Interval:[]} t0:{Success:[true] Interval:[0]} t0dlq:{Success:[] Interval:[]} t1:{Success:[false true] Interval:[0 0]} t1dlq:{Success:[] Interval:[]}]
FAIL
FAIL    knative.dev/eventing/test/rekt/features/broker  0.016s
FAIL

dprotaso commented 3 months ago

/test unit-tests_eventing_main

dprotaso commented 3 months ago

Does TestCreateExpectedEventDeliveryMap have the same problem?

dprotaso commented 3 months ago

Yeah seems like it

creydr commented 3 months ago

Yeah seems like it

I'll check on it...

creydr commented 3 months ago

Addressed in #8023

dprotaso commented 3 months ago

/retest

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.79%. Comparing base (36c904a) to head (c307b55). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8019 +/- ## ======================================= Coverage 67.79% 67.79% ======================================= Files 363 363 Lines 16899 16899 ======================================= Hits 11456 11456 Misses 4735 4735 Partials 708 708 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/eventing/blob/main/OWNERS)~~ [creydr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

knative / eventing

[main] Upgrade to latest dependencies #8019

Codecov Report