Add EventPolicy Reconciler

knative / eventing

Event-driven application platform for Kubernetes

https://knative.dev/docs/eventing

Apache License 2.0

1.39k stars 582 forks source link

Add EventPolicy Reconciler #8024

Closed dharmjit closed 5 days ago

dharmjit commented 1 week ago

Fixes #7973

Proposed Changes

:gift: Add Reconciler for EventPolicy CRD which primarily
- Resolves the identities of .spec.from[].refs and populates them in its status, so the oidc identity of a ref can be seen directly.
- Sets the EventPolicy to Ready / NotReady (e.g. if an identity from a ref could not be resolved)

Pre-review Checklist

[ ] At least 80% unit test coverage
[ ] E2E tests for any new behavior
[ ] Docs PR for any user-facing impact
[ ] Spec PR for any new API feature
[ ] Conformance test for any change to the spec

Release Note

Add EventPolicy Reconciler

Docs

knative-prow[bot] commented 1 week ago

Welcome @dharmjit! It looks like this is your first PR to knative/eventing 🎉

knative-prow[bot] commented 1 week ago

Hi @dharmjit. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

creydr commented 1 week ago

/ok-to-test

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 94.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base (d4e647d) to head (f8edaeb). Report is 8 commits behind head on main.

Files	Patch %	Lines
...kg/apis/eventing/v1alpha1/eventpolicy_lifecycle.go	75.00%	4 Missing :warning:
cmd/controller/main.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8024 +/- ## ========================================== + Coverage 67.70% 67.89% +0.19% ========================================== Files 364 366 +2 Lines 17042 17115 +73 ========================================== + Hits 11538 11621 +83 + Misses 4783 4773 -10 Partials 721 721 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dharmjit commented 1 week ago

/ok-to-test

dharmjit commented 1 week ago

/ok-to-test

knative-prow[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dharmjit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/eventing/blob/main/OWNERS)~~ [creydr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

creydr commented 5 days ago

/test conformance-tests

creydr commented 5 days ago

/test reconciler-tests