Open prajjwalyd opened 1 week ago
Hi @prajjwalyd. Thanks for your PR.
I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/cc @Cali0707 @Leo6Leo
Thank you for reviewing it, @Leo6Leo!
I'm also unsure about where check_k8s_version
should be placed...
maybe creating a subdirectory (/hack/version_check) or something like that?
I'm also unsure about where check_k8s_version should be placed... maybe creating a subdirectory (/hack/version_check) or something like that?
My vote would be to put it in a subdirectory of test
instead of hack
, otherwise I like your idea
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.89%. Comparing base (
f84a98c
) to head (286f730
). Report is 16 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: prajjwalyd Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Fixes #7813
Proposed Changes
Please categorize your changes:
:gift: Added a minimum Kubernetes version check in
install.sh
.check_k8s_version.go
connects to a Kubernetes cluster using the kubeconfig file, then checks if the cluster's version is compatible with the minimum required version specified by Knative. If the version is compatible, it prints a success message; otherwise, it logs an error and exits.When using k8s v1.27.0:![image](https://github.com/knative/eventing/assets/111794524/e51a7032-c767-4978-9ecc-f37f85ddf83e)
When using k8s v1.28.0: (minimum specified version)![image](https://github.com/knative/eventing/assets/111794524/681a161c-f504-4885-9c67-792881f73cb5)
Pre-review Checklist
Release Note
Docs