knative / eventing

Event-driven application platform for Kubernetes
https://knative.dev/docs/eventing
Apache License 2.0
1.39k stars 582 forks source link

Add Kubernetes Version Check to Installation Script #8025

Open prajjwalyd opened 1 week ago

prajjwalyd commented 1 week ago

Fixes #7813

Proposed Changes

Please categorize your changes:

Pre-review Checklist

Release Note

Docs

knative-prow[bot] commented 1 week ago

Hi @prajjwalyd. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
prajjwalyd commented 1 week ago

/cc @Cali0707 @Leo6Leo

prajjwalyd commented 1 week ago

Thank you for reviewing it, @Leo6Leo! I'm also unsure about where check_k8s_version should be placed... maybe creating a subdirectory (/hack/version_check) or something like that?

Cali0707 commented 4 days ago

I'm also unsure about where check_k8s_version should be placed... maybe creating a subdirectory (/hack/version_check) or something like that?

My vote would be to put it in a subdirectory of test instead of hack, otherwise I like your idea

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.89%. Comparing base (f84a98c) to head (286f730). Report is 16 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8025 +/- ## ========================================== + Coverage 67.79% 67.89% +0.10% ========================================== Files 363 366 +3 Lines 16899 17115 +216 ========================================== + Hits 11456 11621 +165 - Misses 4735 4773 +38 - Partials 708 721 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 21 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prajjwalyd Once this PR has been reviewed and has the lgtm label, please assign upodroid for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[hack/OWNERS](https://github.com/knative/eventing/blob/main/hack/OWNERS)** - **[test/OWNERS](https://github.com/knative/eventing/blob/main/test/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment