knative / eventing

Event-driven application platform for Kubernetes
https://knative.dev/docs/eventing
Apache License 2.0
1.39k stars 582 forks source link

Updating RetryableHttp lib to latest #8026

Closed matzew closed 1 week ago

matzew commented 1 week ago

Proposed Changes

Pre-review Checklist

Release Note

Docs

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.70%. Comparing base (d4e647d) to head (144c67b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #8026 +/- ## ======================================= Coverage 67.70% 67.70% ======================================= Files 364 364 Lines 17042 17042 ======================================= Hits 11538 11538 Misses 4783 4783 Partials 721 721 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/eventing/blob/main/OWNERS)~~ [matzew,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
matzew commented 1 week ago

/cherry-pick release-1.14

matzew commented 1 week ago

/cherry-pick release-1.13

knative-prow-robot commented 1 week ago

@matzew: #8026 failed to apply on top of branch "release-1.14":

Applying: lipstick: Updating RetryableHttp lib to latest
Using index info to reconstruct a base tree...
M   go.mod
M   go.sum
M   vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 lipstick: Updating RetryableHttp lib to latest
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/knative/eventing/pull/8026#issuecomment-2188374985): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 1 week ago

@matzew: #8026 failed to apply on top of branch "release-1.13":

Applying: lipstick: Updating RetryableHttp lib to latest
Using index info to reconstruct a base tree...
M   go.mod
M   go.sum
M   vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 lipstick: Updating RetryableHttp lib to latest
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/knative/eventing/pull/8026#issuecomment-2188375143): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.