Event Type API: updated test name to avoid confusion

knative / eventing

Event-driven application platform for Kubernetes

https://knative.dev/docs/eventing

Apache License 2.0

1.41k stars 588 forks source link

Event Type API: updated test name to avoid confusion #8030

Closed matzew closed 3 months ago

matzew commented 3 months ago

Proposed Changes

updated test name to avoid confusion, since empty broker was before broker: "", also added explicit expectation of nil reference.

Pre-review Checklist

[ ] At least 80% unit test coverage
[ ] E2E tests for any new behavior
[ ] Docs PR for any user-facing impact
[ ] Spec PR for any new API feature
[ ] Conformance test for any change to the spec

Release Note

Docs

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/eventing/blob/main/OWNERS)~~ [Cali0707,matzew] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.70%. Comparing base (6352784) to head (b83be3f).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #8030 +/- ## ======================================= Coverage 67.70% 67.70% ======================================= Files 364 364 Lines 17042 17042 ======================================= Hits 11538 11538 Misses 4783 4783 Partials 721 721 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.