search

knative / eventing

Event-driven application platform for Kubernetes
https://knative.dev/docs/eventing
Apache License 2.0
1.39k stars 582 forks source link

Delivery Format: add the `format` field to the Delivery type #8073

Open Cali0707 opened 3 days ago

Cali0707 commented 3 days ago

Problem To support more destinations of cloudevents (which may require a specific event format) we need to add the format field to the DeliverySpec type which is embedded into many of our types.

Persona: Which persona is this feature for?

Exit Criteria The format field is present in the DeliverySpec type, and is validated to be one of:

  1. nil
  2. structured
  3. binary
  4. ingress

Time Estimate (optional): How many developer-days do you think this may take to resolve? 1

Additional context (optional) Add any other context about the feature request here.

Cali0707 commented 3 days ago

/good-first-issue

knative-prow[bot] commented 3 days ago

@Cali0707: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/knative/eventing/issues/8073): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Cali0707 commented 3 days ago

Whoops sorry @EraKin575 I think I messed up the project automation there so this got closed accidentally, I've reopened it now - feel free to ask for help if you need it as you work on it!

EraKin575 commented 3 days ago

thanks! @Cali0707 . I got really confused there

EraKin575 commented 3 days ago

hi @Cali0707 ! is #8057 a prerequisite to this?

Cali0707 commented 3 days ago

hi @Cali0707 ! is #8057 a prerequisite to this?

Nope, this is a sub task for #8057 - this can be worked on now

EraKin575 commented 2 days ago

@Cali0707 this field just needs to be added in the struct and validate in Validate function, right? Nothing else to do?