search

knative / eventing

Event-driven application platform for Kubernetes
https://knative.dev/docs/eventing
Apache License 2.0
1.4k stars 586 forks source link

Delivery Format: set `kn-ingress-format` ce extension on mt channel based broker ingress #8075

Closed Cali0707 closed 1 week ago

Cali0707 commented 2 weeks ago

Problem To support dispatching events from the MTChannelBasedBroker with the correct format when a user sets the spec.delivery.format to ingress, we need to set a cloudevent extension of kn-ingress-format to specify which format was used. This should be set to structured if the input event was structured, and binary if the input event was in binary. However, since this event may have been forwarded from earlier ingress, we need to only set the kn-ingress-format extension if it is not already present on the event.

Persona: Which persona is this feature for?

Exit Criteria Unit tests verifying that:

  1. If the extension is not present it is set correctly for both structured and binary events
  2. If the extension is already present, it is not changed for both structured and binary events

Time Estimate (optional): How many developer-days do you think this may take to resolve? 1-2

Additional context (optional) Add any other context about the feature request here.

Cali0707 commented 2 weeks ago

/good-first-issue

knative-prow[bot] commented 2 weeks ago

@Cali0707: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/knative/eventing/issues/8075): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ckcd commented 2 weeks ago

@Cali0707 may I take this?

rahulii commented 1 week ago

/assign

Cali0707 commented 1 week ago

/close

Hey @rahulii we have made some changes to the design of the larger feature and this issue is no longer needed. Feel free to pick up another open issue and ask us for help on slack. Same goes for you @ckcd - if you want to work on any open unassigned issues all you need to do is comments /assign on the issue