knative / eventing

Event-driven application platform for Kubernetes
https://knative.dev/docs/eventing
Apache License 2.0
1.4k stars 590 forks source link

EventType AutoCreate: set the `specversion` and `id` fields on the eventtypes #8098

Open Cali0707 opened 1 month ago

Cali0707 commented 1 month ago

Problem We recently moved to reconciling the v1beta3 eventtypes, but the eventtype autocreate code is still creating the v1beta2 resources. We should switch to creating v1beta3 resources and setting the specversion field to be the cloudevents spec version of the event that triggered the autocreate, as well as setting the id field on the eventtype (but with no value)

Persona: Which persona is this feature for?

Exit Criteria The eventtype autocreate feature successfully create v1beta3 eventtypes and all existing e2e tests still pass

Time Estimate (optional): How many developer-days do you think this may take to resolve? 1

Additional context (optional) Add any other context about the feature request here.

Cali0707 commented 1 month ago

/help

knative-prow[bot] commented 1 month ago

@Cali0707: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/knative/eventing/issues/8098): >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
iyoshiha commented 1 month ago

I'd like to take care of this problem. Could you please assign it to me?

Cali0707 commented 1 month ago

/assign @iyoshiha

matzew commented 1 month ago

@iyoshiha how is it going? Can we help you?

iyoshiha commented 1 month ago

@iyoshiha how is it going? Can we help you?

@matzew Thank you for your concern. I haven't started working on the problem yet. I will start today and report my progress later.

matzew commented 1 month ago

@iyoshiha sounds good! You can also chat w/ us on the upstream slack channel for #knative-eventing

iyoshiha commented 1 month ago

@matzew hi sorry for the late report. I'm currently facing issues with E2E tests not working properly. I'll keep trying to get it to work. However, if you want to resolve this issue quickly, it might be better to assign it to someone else.

iyoshiha commented 1 month ago

@matzew Actually, I was able to pass the test on the main branch. So, I will work on the parts that actually need to be modified. It will probably take a day or two and I can make a PR.

matzew commented 1 month ago

sure. let use know if you need help. Also review on PR will help to polish the request to go in.

Thanks

iyoshiha commented 1 month ago

@matzew I apologize for my late response due to illness. I will prepare the PR.

rahulii commented 2 days ago

/assign