search

knative / eventing

Event-driven application platform for Kubernetes
https://knative.dev/docs/eventing
Apache License 2.0
1.42k stars 597 forks source link

JobSink controller logs Failed to export to Prometheus: "job-sink_client_latency" is not a valid metric name #8296

Open mgencur opened 2 weeks ago

mgencur commented 2 weeks ago

Describe the bug The job-sink Pod repeatedly reports this:

2024/11/01 15:52:27 Failed to export to Prometheus: "job-sink_client_latency" is not a valid metric name
2024/11/01 15:52:34 Failed to export to Prometheus: "job-sink_client_results" is not a valid metric name
2024/11/01 15:52:34 Failed to export to Prometheus: "job-sink_client_latency" is not a valid metric name

Expected behavior JobSink controller reports metrics properly.

To Reproduce Deploy any JobSink resource.

Knative release version 1.15

Additional context Add any other context about the problem here such as proposed priority

pierDipi commented 1 week ago

We need to remove the dash from the component name https://github.com/knative/eventing/blob/f53d038a4ab908b1eb57da39117cfc34d6163c7c/cmd/jobsink/main.go#L68

/good-first-issue

knative-prow[bot] commented 1 week ago

@pierDipi: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/knative/eventing/issues/8296): >We need to remove the dash from the component name >https://github.com/knative/eventing/blob/f53d038a4ab908b1eb57da39117cfc34d6163c7c/cmd/jobsink/main.go#L68 > >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yatesliang commented 4 hours ago

Is it okay to rename the component job_sink? To obey the Prometheus naming rules: https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels