search

knative / eventing

Event-driven application platform for Kubernetes
https://knative.dev/docs/eventing
Apache License 2.0
1.41k stars 595 forks source link

e2e test for simple delivery #931

Closed chizhg closed 5 years ago

chizhg commented 5 years ago

Currently we do not have an e2e test case for the simple delivery scenario - direct delivery from a source to a single service.

I would like to add one as my start in this project.

/kind feature-request /assign @Fredy-Z

evankanderson commented 5 years ago

If you are only testing direct Source --> Service delivery, you may want to do your work in eventing-sources. I think @bbrowning may have recently added a test here: https://github.com/knative/eventing-sources/tree/master/test/e2e

chizhg commented 5 years ago

If you are only testing direct Source --> Service delivery, you may want to do your work in eventing-sources. I think @bbrowning may have recently added a test here: https://github.com/knative/eventing-sources/tree/master/test/e2e

I see, thanks for letting me know, Evan. Do you think if a test case that has one channel and multiple subscriptions will be useful? I was just thinking about working on a simple scenario as a warm-up and of course making some contributions :-) If it works, I can turn to this implementation. Thanks!

evankanderson commented 5 years ago

I think that test only works for a specific source (the kubernetes event source). Testing another source such as cron or containersource (we have a lot of containersources) would be useful there.

In this repo, tests for one Channel with multiple subscriptions or or multiple Channels (no event leakage between channels) would be useful, as would tests for Broker and Trigger (@Harwayne could point out some needed additional tests).

chizhg commented 5 years ago

Close this issue, will turn to working on #940 /close

knative-prow-robot commented 5 years ago

@Fredy-Z: Closing this issue.

In response to [this](https://github.com/knative/eventing/issues/931#issuecomment-475064342): >Close this issue, will turn to working on #940 >/close > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.