search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Skip Prow integration tests for PRs that only updates GitHub Actions #153

Closed chizhg closed 2 years ago

chizhg commented 2 years ago

For PRs that updates GitHub Actions workflow files, such as https://github.com/knative/serving/pull/12582, there is no need to run the Prow integration tests, so we should consider skipping them.

It can be as easy as adding a regex in https://github.com/knative/hack/blob/main/presubmit-tests.sh#L26, but we should make sure a folder path is supported there since currently the list only contains file paths.

chizhg commented 2 years ago

/kind good-first-issue

chizhg commented 2 years ago

Tried https://github.com/knative/hack/pull/154 and https://github.com/knative/hack/pull/156 to fix the issue, but it's still not working for https://github.com/knative/test-infra/pull/3110... I tried to run the command locally and it actually worked. Bash is very magical to me...

krsna-m commented 2 years ago

/assign kvmware

krsna-m commented 2 years ago

/kind cncf-infra

chizhg commented 2 years ago

With Fabian's work on reusable workflow, this becomes less important since there'll be much less chance to populate the Actions file updates to every repo.