search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Fix the regex used for matching GitHub Actions files #156

Closed chizhg closed 2 years ago

chizhg commented 2 years ago

I don't remember why I had the wrong impression that regex used for grep didn't need ., apparently it needs...

knative-prow-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chizhg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [chizhg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chizhg commented 2 years ago

/cc @kvmware

krsna-m commented 2 years ago

/lgtm