search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

`DISABLE_MD_LINTING` and `DISABLE_MD_LINK_CHECK` are dead variables #200

Closed krsna-m closed 2 years ago

krsna-m commented 2 years ago

As part of https://github.com/knative/hack/pull/199 those env var are never used, yet littered through out our repos. This should be cleaned up. https://cs.github.com/?q=org%3Aknative+DISABLE_MD_LINTING

kellyaa commented 2 years ago

I think we can close since the mentioned PRs are merged - Agree or disagree @kvmware ?

krsna-m commented 2 years ago

Again thanks for the awesome work! Based on https://cs.github.com/?q=org%3Aknative+DISABLE_MD_LINTING I see that there is a lot of references to that var in test-infra. Once that is purged I think we are good on this issue :+1:

krsna-m commented 2 years ago

Thanks again!