search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Hacks needs to be sourced without the vendor directory #221

Closed cardil closed 1 year ago

cardil commented 2 years ago

Currently, the hack scripts are being sourced from vendor/ directory. To stop relying on hack being in vendor we need a different way to provide the scripts to the projects.

There were at least two proposals:

  1. Sync the hack scripts to projects using a robot, preferably using git subtree to keep the separation. (@upodroid idea)
  2. Embed Bash scripts withing some hack binary. That binary, when executed, will extract them to a temporary directory, and provide the path to the scripts, so they could be sourced. (@cardil idea)
cardil commented 2 years ago

We'll try the 2nd proposal.