search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

:gift: Use modscope tool to get info about Go modules #223

Closed cardil closed 2 years ago

cardil commented 2 years ago

Changes

/kind enhancement

Fixes #220

cardil commented 2 years ago

/assign @upodroid /assign @kvmware /cc @mgencur

krsna-m commented 2 years ago

LGTM, but I would like to you to run the shell scripts being changed through shellcheck https://www.shellcheck.net/ or use the action reusable-style.yaml from actions repo

cardil commented 2 years ago

I run shellcheck in my IDE, already.

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [cardil,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment