search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Signing should respect the ARTIFACTS_TO_PUBLISH variable #240

Closed cardil closed 1 year ago

cardil commented 2 years ago

The code signing should respect the ARTIFACTS_TO_PUBLISH variable. If the variable contains the checksums.txt file, that file should be updated.

Current code expects the artifacts to live in project root.

https://github.com/knative/hack/blob/cf1a127cfdcd88b1d74fec195089a2090178a596/release.sh#L316-L359

/kind bug

cardil commented 2 years ago

/cc @upodroid

I can provide a fix for this, but after I finish my other tasks.

upodroid commented 2 years ago

Go ahead

cardil commented 1 year ago

The https://github.com/knative-sandbox/homebrew-kn-plugins/issues/134 is caused by this.