search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

drop support for the istio add on flag #243

Closed dprotaso closed 2 years ago

dprotaso commented 2 years ago

This thing is so old and we don't use it so drop it.

In the past we would be install the Istio add-on available in GKE but we ended up installing it ourselves.

dprotaso commented 2 years ago

/assign @kvmware @upodroid

dprotaso commented 2 years ago

I don't understand the error in the unit test cc @cardil

cardil commented 2 years ago

The unit tests expect the script output to have:

kubectl wait job --for=condition=Complete --all -n istio-system --timeout=5m

I guess you should adjust that assertion appropriately.

https://github.com/knative/hack/blob/4b6bd86dae9d64d8ed8b10857c5dc1275e866f86/test/unit/run_e2e_test.go#L18

dprotaso commented 2 years ago

The unit tests expect the script output to have:

Ah - the error message in the test could have been more clear

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [dprotaso,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment