search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

KO_DATA_PATH doesn't need to be set anymore #244

Closed dprotaso closed 2 years ago

dprotaso commented 2 years ago

We read the version control from the go binary now

dprotaso commented 2 years ago

/assign @kvmware @upodroid

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [dprotaso,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
upodroid commented 2 years ago

/easycla