Closed dprotaso closed 2 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dprotaso
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Actually I think the trap command should be LIFO and that would solve this problem
Ok - done please take a look
/lgtm
We tend to add traps at various points in our test scripts. The assumption we have is the trap will be executed when external resources are in a certain state.
ie.
Prior traps are executed in FIFO order so the cluster would be torn down before the test dump would occur.
In LIFO order the test dump would occur first, then the teardown of knative and then finally the cluster.
/assign @cardil /assign @upodroid