e2e script tweaks - Githubissues

knative / hack

Knative common scripts.

Apache License 2.0

18 stars 64 forks source link

e2e script tweaks #252

Closed dprotaso closed 2 years ago

dprotaso commented 2 years ago

Don't dump_metrics by default - provide on_success & on_failure hooks as an alternative
make env teardown optional

/hold going to test downstream

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

dprotaso commented 2 years ago

serving test - https://github.com/knative/serving/pull/13468

dprotaso commented 2 years ago

eventing - https://github.com/knative/eventing/pull/6610

dprotaso commented 2 years ago

/hold E2E_SCRIPT needs to be set

dprotaso commented 2 years ago

/hold cancel

krsna-m commented 2 years ago

/lgtm

krsna-m commented 2 years ago

this is great!