search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

:bug: Don't use NodeLocalDNS addon #257

Closed cardil closed 2 years ago

cardil commented 2 years ago

Changes

/kind bug

Fixes partially https://github.com/knative-sandbox/kn-plugin-event/issues/242

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [cardil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cardil commented 2 years ago

/assign @dprotaso /assign @upodroid /assign @kvmware /cc @mgencur

cardil commented 2 years ago

Here's a justification of this change: https://github.com/knative-sandbox/kn-plugin-event/issues/242#issuecomment-1322745383

Here's a related guide from Google: https://cloud.google.com/kubernetes-engine/docs/how-to/nodelocal-dns-cache#known_issues

krsna-m commented 2 years ago

/lgtm

krsna-m commented 2 years ago

/lgtm

krsna-m commented 2 years ago

Sorry misclicked close instead of comment for the /lgtm, my bad :/

cardil commented 2 years ago

It turns out the NodeLocalDNS wasn't the culprit... I did run 9 runs in a row using production GKE with NodeLocalDNS enabled. No errors. Same on https://github.com/knative-sandbox/kn-plugin-event/pull/250 already 3 runs in a row.

258 will revert this (without the kubetest2 convenience install).