search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Darwin artifact signing should look up a checksums file in ARTIFACTS_TO_PUBLISH variable #266

Closed cardil closed 1 year ago

cardil commented 1 year ago

https://github.com/knative/hack/blob/c7cfcb062de90832da2423d92cd0135706ee07a0/release.sh#L337-L350

The above code should search the ARTIFACTS_TO_PUBLISH variable to look for the location of the checksums file. Currently, it expects the checksums to be in the root folder of the project. This is the cause of the https://github.com/knative-sandbox/homebrew-kn-plugins/issues/134 problem.

/kind bug

upodroid commented 1 year ago

possible dupe of #240?

cardil commented 1 year ago

Right, let's close this in favor of #240

/close

knative-prow[bot] commented 1 year ago

@cardil: Closing this issue.

In response to [this](https://github.com/knative/hack/issues/266#issuecomment-1419847639): >Right, let's close this in favor of #240 > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.