search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Add shellcheck linter #269

Closed krsna-m closed 1 year ago

krsna-m commented 1 year ago

This repo is mostly bash scripts and shellcheck helps us have secure good bash.

Our actions repo has a shellcheck linter reusable github action that should be used.

kauana commented 1 year ago

/assign @kauana

kauana commented 1 year ago

Hey @kvmware,

Do we want to run the action on opened PRs? If so, only on main and release- branches?

Thanks

krsna-m commented 1 year ago

Yea, the shellcheck linter and how it should be ran (example) should be in the knative/actions repo.

Thanks for looking into this!

kauana commented 1 year ago

@kvmware now that #289 was merged, maybe we can close this issue too?