search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Set GitHub Release Title to the version of the release #277

Closed dprotaso closed 1 year ago

dprotaso commented 1 year ago

Shortening this

Screenshot 2023-02-27 at 11 36 25 AM

to

Screenshot 2023-02-27 at 11 37 02 AM

dprotaso commented 1 year ago

@cardil I don't know what's going on with these unit tests

    sharedlib_test.go:67: 
            Error Trace:    /home/prow/go/src/knative.dev/hack/test/unit/sharedlib_test.go:67
                                        /home/prow/go/src/knative.dev/hack/test/unit/sharedlib_test.go:97
            Error:          Not equal: 
                            expected: ""
                            actual  : "Error: cannot list tags: lstat /home/prow/go/src/knative.dev/hack/test/unit/unittest-RmC09gAzsjtw.bash: no such file or directoryexit status 21\n"

                            Diff:
                            --- Expected
                            +++ Actual
                            @@ -1 +1,2 @@
                            +Error: cannot list tags: lstat /home/prow/go/src/knative.dev/hack/test/unit/unittest-RmC09gAzsjtw.bash: no such file or directoryexit status 21

            Test:           TestMainFunc/main_--build-tests
dprotaso commented 1 year ago

/assign @kvmware @upodroid

cardil commented 1 year ago

It looks to me like a fluke. Maybe a file collision on file unittest-RmC09gAzsjtw.bash?! First time I see such failure. It works on my PC. Retesting.

/approve /lgtm

/test unit-tests

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [cardil,dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment