search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

:bug: Collect LICENSE files from all dependencies, even without vendor dir #316

Closed cardil closed 1 year ago

cardil commented 1 year ago

Changes

/kind bug

Fixes #315

Release Note

The license files are collected, even if a project doesn't have the vendor directory
cardil commented 1 year ago

/cc @dprotaso /cc @upodroid /cc @kvmware

dprotaso commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

@upodroid: Overrode contexts on behalf of upodroid: style / suggester / shell

In response to [this](https://github.com/knative/hack/pull/316#pullrequestreview-1638064552): >/override "style / suggester / shell" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [cardil,dprotaso,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment