search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Use `kube-codegen.sh` instead of `generate-groups.sh` when moving to k8s.io api `0.28+` #336

Closed andrew-su closed 2 months ago

andrew-su commented 1 year ago

As of k8s.io/code-generator@v0.28.0, the script generate-groups.sh is deprecated and we should move to using kube-codegen.sh

andrew-su commented 1 year ago

Related: #335

cardil commented 2 months ago

The Kube v0.30 removed the generate-groups.sh contents, which in turn renders Knative code-generation broken.

Knative already rolled to Kube v0.30, for example: https://github.com/knative/serving/pull/15462, https://github.com/knative/eventing/pull/8126, so this essentailly prevents changes to any Knative CRDs.

As discussed in the Productivity WG, I will create a generate-groups like tool in Knative ASAP, and notify Knative working groups on migration steps in all the Knative projects, that use code-gen.

/assign /kind bug

matzew commented 2 months ago

Thanks a lot, @cardil

cardil commented 2 months ago

Some maintainers already started doing the migration to kube_codegen.sh script:

And because it looks like it shouldn't be super hard, we decided it makes sense to just go with it, so the interim generate-groups.sh shim (that I proposed on Productivity WG) wouldn't be required.

We created the doc to track the migration effort: https://docs.google.com/spreadsheets/d/12OG7kLYlJIz-vOKihdtG1Vtrg0OsD8vF_umJLFK0_kQ

/close

knative-prow[bot] commented 2 months ago

@cardil: Closing this issue.

In response to [this](https://github.com/knative/hack/issues/336#issuecomment-2324802473): >Some maintainers already started doing the migration to kube_codegen.sh script: > >- https://github.com/knative-extensions/eventing-istio/pull/486 >- https://github.com/knative/eventing/pull/8183 >- https://github.com/knative-extensions/security-guard/pull/312 > >And because it looks like it shouldn't be super hard, we decided it makes sense to just go with it, so the interim generate-groups.sh shim (that I proposed on Productivity WG) wouldn't be required. > >We created the doc to track the migration effort: https://docs.google.com/spreadsheets/d/12OG7kLYlJIz-vOKihdtG1Vtrg0OsD8vF_umJLFK0_kQ > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.