search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Adding the variable `KNATIVE_EVENTING_RELEASE_TLS` to install latest eventing TLS #350

Closed Leo6Leo closed 1 year ago

Leo6Leo commented 1 year ago

Changes

Release Note

Adding the option to install knative eventing TLS component

Docs

Leo6Leo commented 1 year ago

/cc @pierDipi

pierDipi commented 1 year ago

One comment

/approve

Leo6Leo commented 1 year ago

/cc @Cali0707

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [Cali0707,pierDipi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Leo6Leo commented 1 year ago

/cherry-pick release-1.11

knative-prow-robot commented 1 year ago

@Leo6Leo: new pull request created: #351

In response to [this](https://github.com/knative/hack/pull/350#issuecomment-1823277164): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Leo6Leo commented 1 year ago

/cherry-pick release-1.12

knative-prow-robot commented 1 year ago

@Leo6Leo: new pull request created: #352

In response to [this](https://github.com/knative/hack/pull/350#issuecomment-1823289052): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 12 months ago

@Leo6Leo: #350 failed to apply on top of branch "release-1.12":

Applying: Adding the variable to install latest eventing tls
Using index info to reconstruct a base tree...
M   library.sh
Falling back to patching base and 3-way merge...
Auto-merging library.sh
CONFLICT (content): Merge conflict in library.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Adding the variable to install latest eventing tls
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/knative/hack/pull/350#issuecomment-1834366101): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.