search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

drop toolchain directive #369

Closed dprotaso closed 9 months ago

dprotaso commented 9 months ago

Toolchain directive isn't necessary - and it's breaking go-licenses.

This is a workaround that drops it when updating dependencies.

knative-prow[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 9 months ago

/hold

dprotaso commented 9 months ago

tested this with serving seems good - go mod vendor doesn't add it back

/hold cancel

izabelacg commented 9 months ago

/lgtm