search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Set default for GKE version to 1.28 #370

Closed creydr closed 9 months ago

creydr commented 9 months ago

Currently we use the GKE default version for our GKE test clusters (https://cloud.google.com/kubernetes-engine/docs/release-notes-nochannel). This can lead to problems when GKEs version is behind Knatives defined min Kubernetes version and if repositories don't set it via the --cluster-version parameter.

This PR addresses it, and sets a Knative default for GKE test clusters. Unfortunately this comes with the cost of maintaining this version - but can be reverted, when GKE uses a more recent version as default again.

dprotaso commented 9 months ago

/lgtm /approve

knative-prow[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [creydr,dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment