search

knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Remove geo replication for GCR #389

Closed upodroid closed 3 months ago

upodroid commented 3 months ago

We have been doing geo-replication for a long time, but it's costly and we don't tell our end-users about it.

It costs about 4x to store images in Artifact Registry vs Container Registry. 0.10 USD vs 0.026 USD for a multiregion GCS bucket.

image

Storing in just gcr.io/knative-nightly which is the US multi-region should be sufficient.

/cc @dprotaso @cardil

dprotaso commented 3 months ago

/lgtm /approve

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [dprotaso,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 3 months ago

/cherry-pick release-1.15

knative-prow-robot commented 3 months ago

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to [this](https://github.com/knative/hack/pull/389#issuecomment-2264181423): >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dprotaso commented 3 months ago

/cherry-pick release-1.14

knative-prow-robot commented 3 months ago

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to [this](https://github.com/knative/hack/pull/389#issuecomment-2264181475): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dprotaso commented 3 months ago

Note - for the changes to take effect in release branches downstream repos need to update their knative.dev/hack dependency

knative-prow-robot commented 3 months ago

@dprotaso: new pull request created: #390

In response to [this](https://github.com/knative/hack/pull/389#issuecomment-2264181423): >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dprotaso commented 3 months ago

Also @upodroid to save on cost should we delete the extra images in those regions?

knative-prow-robot commented 3 months ago

@dprotaso: new pull request created: #391

In response to [this](https://github.com/knative/hack/pull/389#issuecomment-2264181475): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
upodroid commented 3 months ago

I will delete the registries in knative-nightly project today.

I haven't migrated the prod one yet.