knative / hack

Knative common scripts.
Apache License 2.0
18 stars 64 forks source link

Tag images using ko #393

Closed upodroid closed 3 months ago

upodroid commented 3 months ago

389 introduced a bug. The code I deleted in that PR was adding the git tags to the docker images. Now the git tag is passed to ko directly.

Tested with operator at https://console.cloud.google.com/artifacts/docker/knative-nightly/us/gcr.io/knative.dev%2Foperator%2Fcmd%2Foperator?project=knative-nightly

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/hack/blob/main/OWNERS)~~ [cardil,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 3 months ago

/cherry-pick release-1.15

dprotaso commented 3 months ago

/cherry-pick release-1.14

knative-prow-robot commented 3 months ago

@dprotaso: new pull request created: #394

In response to [this](https://github.com/knative/hack/pull/393#issuecomment-2288806924): >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 3 months ago

@dprotaso: new pull request created: #395

In response to [this](https://github.com/knative/hack/pull/393#issuecomment-2288807076): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.