search

knative / infra

Home of Infra (Productivity) that hosts configs for prow and other infrastructure related things.
Apache License 2.0
8 stars 27 forks source link

Prow build tests for Backstage stuff #507

Closed aliok closed 3 months ago

aliok commented 3 months ago

Which issue(s) this PR fixes:
Fixes

dsimansk commented 3 months ago

Ali, looks good to me. Check is passing, it should be fine. Also assuming that the script exists /test/presubmit-tests.sh on the backstage side.

/approve /lgtm

/hold for other reviews

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/infra/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pierDipi commented 3 months ago

/unhold

knative-prow[bot] commented 3 months ago

@aliok: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/infra/pull/507): > >**Which issue(s) this PR fixes**:
>Fixes > > > > > > > > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.