search

knative / infra

Home of Infra (Productivity) that hosts configs for prow and other infrastructure related things.
Apache License 2.0
8 stars 27 forks source link

Use testgrid's configurator image from gcr.io registry #521

Closed dsimansk closed 1 month ago

dsimansk commented 1 month ago

Address issue described in: https://github.com/knative/infra/pull/520#issuecomment-2379238805

/cc @upodroid in case this's actual source of latest image for testgrid's configurator.

cardil commented 1 month ago

Looks okay to me. Let @upodroid take a look...

/cc @upodroid

dsimansk commented 1 month ago

Just as a sanity check, pull-infra-validate-own-testgrid-yaml will keep failing until image is updated.

dsimansk commented 1 month ago

@upodroid @cardil updated per review suggestion to staging image location. PTAL

knative-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/infra/blob/main/OWNERS)~~ [dsimansk,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
upodroid commented 1 month ago

/lgtm

upodroid commented 1 month ago

/override pull-infra-validate-own-testgrid-yaml

knative-prow[bot] commented 1 month ago

@upodroid: Overrode contexts on behalf of upodroid: pull-infra-validate-own-testgrid-yaml

In response to [this](https://github.com/knative/infra/pull/521#issuecomment-2382978363): >/override pull-infra-validate-own-testgrid-yaml Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 1 month ago

@dsimansk: Updated the job-config configmap in namespace default at cluster default using the following files:

In response to [this](https://github.com/knative/infra/pull/521): >- Use testgrid's configurator image from gcr.io registry > >Address issue described in: https://github.com/knative/infra/pull/520#issuecomment-2379238805 > > >/cc @upodroid in case this's actual source of latest image for testgrid's configurator. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.